Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce bundle size by fixing material-icon imports #2351

Conversation

semery-fractalev
Copy link
Contributor

* Reduce size of bundles by avoiding `import X from '@mui/icons-material'` style import statements
* Fixes eclipsesource#2350
@CLAassistant
Copy link

CLAassistant commented Jul 3, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented Jul 3, 2024

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 2581ebd
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/668559eee3c19b0008576b9f
😎 Deploy Preview https://deploy-preview-2351--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sdirix
Copy link
Member

sdirix commented Jul 3, 2024

Thank you very much! ❤️

@coveralls
Copy link

Coverage Status

coverage: 83.341% (+0.004%) from 83.337%
when pulling 2581ebd on semery-fractalev:fix/2350-icons-material-import-format
into c3cead7 on eclipsesource:master.

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdirix sdirix merged commit 635faab into eclipsesource:master Jul 3, 2024
8 checks passed
@semery-fractalev semery-fractalev deleted the fix/2350-icons-material-import-format branch July 3, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@mui/icons-material imports balloon bundle sizes
4 participants